)]}'
{
  "commit": "0175ba109eb0c098a00903887328393c2e17d4ae",
  "tree": "400ba5c96ecc4d7b21c0dc1fd013b28f0554d608",
  "parents": [
    "65cd9064e13f2388d3bd9c815826f5db6b0b13ec"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Fri Apr 25 12:44:23 2014 +0200"
  },
  "committer": {
    "name": "Andreas Färber",
    "email": "afaerber@suse.de",
    "time": "Mon May 05 19:08:49 2014 +0200"
  },
  "message": "arm: Clean up fragile use of error_is_set() in realize() methods\n\nUsing error_is_set(ERRP) to find out whether a function failed is\neither wrong, fragile, or unnecessarily opaque.  It\u0027s wrong when ERRP\nmay be null, because errors go undetected when it is.  It\u0027s fragile\nwhen proving ERRP non-null involves a non-local argument.  Else, it\u0027s\nunnecessarily opaque (see commit 84d18f0).\n\nI guess the error_is_set(errp) in the DeviceClass realize() methods\nare merely fragile right now, because I can\u0027t find a call chain that\npasses a null errp argument.\n\nMake the code more robust and more obviously correct: receive the\nerror in a local variable, then propagate it through the parameter.\n\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nAcked-by: Peter Maydell \u003cpeter.maydell@linaro.org\u003e\nSigned-off-by: Andreas Färber \u003cafaerber@suse.de\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "955b8d4945513fe0c20e69cb4eb9937da251cc1c",
      "old_mode": 33188,
      "old_path": "hw/intc/arm_gic.c",
      "new_id": "1532ef94824a2d819130a945f86cd3958d00ba03",
      "new_mode": 33188,
      "new_path": "hw/intc/arm_gic.c"
    },
    {
      "type": "modify",
      "old_id": "719d2277ec2f849703089aae56ee0ed13631ebbc",
      "old_mode": 33188,
      "old_path": "hw/intc/arm_gic_kvm.c",
      "new_id": "5038885afdff2abfd81164df55b11a5e740361dc",
      "new_mode": 33188,
      "new_path": "hw/intc/arm_gic_kvm.c"
    },
    {
      "type": "modify",
      "old_id": "f5b0c3be6f280191410a2911f294a2e49b741de1",
      "old_mode": 33188,
      "old_path": "hw/intc/armv7m_nvic.c",
      "new_id": "9aa8ab208f156ab4030191ca395dd5365192c98c",
      "new_mode": 33188,
      "new_path": "hw/intc/armv7m_nvic.c"
    }
  ]
}