commit 04c5b17a74c9d6c309181079f8949665b43b0164
author Markus Armbruster <armbru@redhat.com> Tue Nov 08 15:36:50 2011 +0100
committer Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Thu Nov 10 12:29:50 2011 +0000
tree 787909f87c1fdef9888d3de8f322af51d300e879
parent 99e1dec06f343cefecae9baeec0aae2f99f552d5

x86/cpuid: Fix crash on -cpu ""

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

target-i386/cpuid.c

diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index 99cff65..21e5896 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -594,9 +594,9 @@
     uint32_t numvalue;
 
     for (def = x86_defs; def; def = def->next)
-        if (!strcmp(name, def->name))
+        if (name && !strcmp(name, def->name))
             break;
-    if (kvm_enabled() && strcmp(name, "host") == 0) {
+    if (kvm_enabled() && name && strcmp(name, "host") == 0) {
         cpu_x86_fill_host(x86_cpu_def);
     } else if (!def) {
         goto error;