commit 04f8c053cca9c329eebb761f3a1ffef3d349b84c
author Luiz Capitulino <lcapitulino@redhat.com> Tue Apr 06 16:39:42 2010 -0300
committer Luiz Capitulino <lcapitulino@redhat.com> Mon Apr 26 11:17:19 2010 -0300
tree f46d68dba72583e2714d790a82dfd6fced1b6f3c
parent abaf2f52716625d4b1e29204cab644ed656504cf

QMP: Check "arguments" member's type

Otherwise the following input crashes QEMU:

{ "execute": "migrate", "arguments": "tcp:0:4446" }

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

monitor.c

diff --git a/monitor.c b/monitor.c
index 0611b29..ef84298 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4437,6 +4437,9 @@
     obj = qdict_get(input, "arguments");
     if (!obj) {
         args = qdict_new();
+    } else if (qobject_type(obj) != QTYPE_QDICT) {
+        qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "arguments", "object");
+        goto err_input;
     } else {
         args = qobject_to_qdict(obj);
         QINCREF(args);