)]}'
{
  "commit": "0aff637e920c0cdb74338c6f57005f2d7cab63d6",
  "tree": "84147a3754c8ec1434ecc26291cb4d43e903b0dd",
  "parents": [
    "5f758366c0710d23e43f4d0f83816b98616a13d0"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Mon May 19 18:57:35 2014 +0200"
  },
  "committer": {
    "name": "Gerd Hoffmann",
    "email": "kraxel@redhat.com",
    "time": "Wed May 21 11:57:58 2014 +0200"
  },
  "message": "char: Clean up fragile use of error_is_set()\n\nUsing error_is_set(ERRP) to find out whether a function failed is\neither wrong, fragile, or unnecessarily opaque.  It\u0027s wrong when ERRP\nmay be null, because errors go undetected when it is.  It\u0027s fragile\nwhen proving ERRP non-null involves a non-local argument.  Else, it\u0027s\nunnecessarily opaque (see commit 84d18f0).\n\nThe error_is_set(errp) in qemu_chr_new_from_opts() is merely fragile,\nbecause the callers never pass a null errp argument.\n\nMake the code more robust and more obviously correct: receive the\nerror in a local variable, then propagate it through the parameter.\n\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nSigned-off-by: Gerd Hoffmann \u003ckraxel@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3eaefc9244be810ae7568c2e83f294c12b40043e",
      "old_mode": 33188,
      "old_path": "qemu-char.c",
      "new_id": "5a7975f39390c08661f1e54f764f715ff1fe0c58",
      "new_mode": 33188,
      "new_path": "qemu-char.c"
    }
  ]
}