tree 84147a3754c8ec1434ecc26291cb4d43e903b0dd
parent 5f758366c0710d23e43f4d0f83816b98616a13d0
author Markus Armbruster <armbru@redhat.com> 1400518655 +0200
committer Gerd Hoffmann <kraxel@redhat.com> 1400666278 +0200

char: Clean up fragile use of error_is_set()

Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque.  It's wrong when ERRP
may be null, because errors go undetected when it is.  It's fragile
when proving ERRP non-null involves a non-local argument.  Else, it's
unnecessarily opaque (see commit 84d18f0).

The error_is_set(errp) in qemu_chr_new_from_opts() is merely fragile,
because the callers never pass a null errp argument.

Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>