commit 1a688d3bbc2a44bfefa3f6774a11b0385dafc029
author Gerd Hoffmann <kraxel@redhat.com> Tue Dec 08 13:11:36 2009 +0100
committer Anthony Liguori <aliguori@us.ibm.com> Sat Dec 12 07:59:41 2009 -0600
tree 8b162b2bdc8918d1c239f110bc482334e465f203
parent 07a8de3566bd576dc33e55af830d63dcc2287617

chardev: make chardevs specified in config file work.

The patch decuples the -chardev switch and the actual chardev
initialization.  Without this patch qemu ignores chardev entries
coming via -readconfig.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

vl.c

diff --git a/vl.c b/vl.c
index f7acdd4..aa678ad 100644
--- a/vl.c
+++ b/vl.c
@@ -4586,6 +4586,16 @@
     return 0;
 }
 
+static int chardev_init_func(QemuOpts *opts, void *opaque)
+{
+    CharDriverState *chr;
+
+    chr = qemu_chr_open_opts(opts, NULL);
+    if (!chr)
+        return -1;
+    return 0;
+}
+
 struct device_config {
     enum {
         DEV_USB,       /* -usbdevice   */
@@ -5180,9 +5190,6 @@
                     fprintf(stderr, "parse error: %s\n", optarg);
                     exit(1);
                 }
-                if (qemu_chr_open_opts(opts, NULL) == NULL) {
-                    exit(1);
-                }
                 break;
             case QEMU_OPTION_serial:
                 if (serial_device_index >= MAX_SERIAL_PORTS) {
@@ -5501,6 +5508,9 @@
        }
     }
 
+    if (qemu_opts_foreach(&qemu_chardev_opts, chardev_init_func, NULL, 1) != 0)
+        exit(1);
+
 #ifndef _WIN32
     if (daemonize) {
 	pid_t pid;