)]}'
{
  "commit": "212789925efffe1c552b114321ee74081a7efb03",
  "tree": "e1bcc2f2968a6c769db21c6dee0f374e9936dd30",
  "parents": [
    "d8683155fa76cabff112271771e43e21034ff2ba"
  ],
  "author": {
    "name": "Bo Tu",
    "email": "tubo@linux.vnet.ibm.com",
    "time": "Fri Jul 03 15:28:49 2015 +0800"
  },
  "committer": {
    "name": "Kevin Wolf",
    "email": "kwolf@redhat.com",
    "time": "Fri Sep 04 20:59:48 2015 +0200"
  },
  "message": "qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts\n\nwhen creating an image qemu-img enable us specifying the size of the\nimage using -o size\u003dxx options. But when we specify an invalid size\nsuch as a negtive size then different platform gives different result.\n\nparse_option_size() function in util/qemu-option.c will be called to\nparse the size, a cast was called in the function to cast the input\n(saved as a double in the function) size to an unsigned int64 value,\nwhen the input is a negtive value or exceeds the maximum of uint64, then\nthe result is undefined.\n\nAccording to C99 6.3.1.4, the result of converting a floating point\nnumber to an integer that cannot represent the (integer part of) number\nis undefined.  And sure enough the results are different on x86 and\ns390.\n\nC99 Language spec 6.3.1.4 Real floating and integers:\nthe result of this assignment/cast is undefined if the float is not\nin the open interval (-1, U\u003ctype\u003e_MAX+1).\n\nReviewed-by: Max Reitz \u003cmreitz@redhat.com\u003e\nReviewed-by: Sascha Silbe \u003csilbe@linux.vnet.ibm.com\u003e\nSigned-off-by: Bo Tu \u003ctubo@linux.vnet.ibm.com\u003e\nSigned-off-by: Kevin Wolf \u003ckwolf@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9f93666c5b539e805a6dd754a44a2673b8ddc887",
      "old_mode": 33188,
      "old_path": "tests/qemu-iotests/049.out",
      "new_id": "8884543db99a3ae457903a3af3ae17cffecfa60d",
      "new_mode": 33188,
      "new_path": "tests/qemu-iotests/049.out"
    },
    {
      "type": "modify",
      "old_id": "efe9d279c423e15c16069b6c091ce5bc8748aa6c",
      "old_mode": 33188,
      "old_path": "util/qemu-option.c",
      "new_id": "efd6f024e7ebb8c2cc26b7725ff316d326ab3828",
      "new_mode": 33188,
      "new_path": "util/qemu-option.c"
    }
  ]
}