commit 2313e998d7bf55d02499ee162fb4558af4fbb3f5
author Jan Kiszka <jan.kiszka@siemens.com> Fri Sep 16 00:47:55 2011 +0200
committer Anthony Liguori <aliguori@us.ibm.com> Fri Sep 16 08:25:57 2011 -0500
tree 0983b4a08e3458f79a2564ce23778158efc7724e
parent d9389b9664df561db796b18eb8309fffe58faf8b

vga: Fix text mode screendumps

In text mode, even a full refresh of the screen takes multiple updates.
As we reset the dump file pointer after the first call, we only wrote
the first line.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

hw/vga.c

diff --git a/hw/vga.c b/hw/vga.c
index 125fb29..7be5141 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -149,7 +149,7 @@
 static uint8_t expand4to8[16];
 
 static void vga_screen_dump(void *opaque, const char *filename);
-static char *screen_dump_filename;
+static const char *screen_dump_filename;
 static DisplayChangeListener *screen_dump_dcl;
 
 static void vga_update_memory_access(VGACommonState *s)
@@ -2318,7 +2318,6 @@
 {
     if (screen_dump_filename) {
         ppm_save(screen_dump_filename, ds->surface);
-        screen_dump_filename = NULL;
     }
 }
 
@@ -2396,8 +2395,8 @@
     if (!screen_dump_dcl)
         screen_dump_dcl = vga_screen_dump_init(s->ds);
 
-    screen_dump_filename = (char *)filename;
+    screen_dump_filename = filename;
     vga_invalidate_display(s);
     vga_hw_update();
+    screen_dump_filename = NULL;
 }
-