tree c40d15681c1e8d51a5f2979438b1e1b6f9acbefc
parent 30cb4cdec79dc2727f562edee36a4f3df4dfc23f
author Peter Maydell <peter.maydell@linaro.org> 1299775729 +0000
committer Aurelien Jarno <aurelien@aurel32.net> 1300776755 +0100

target-arm: Fix UNDEF cases in Thumb load/store

Decode of Thumb load/store was merging together the cases of 'bit 11==0'
(reg+reg LSL imm) and 'bit 11==1' (reg+imm). This happens to work for
valid instruction patterns but meant that we would not UNDEF for the
cases the architecture mandates that we must. Make the decode actually
look at bit 11 as well as [10..8] so that we UNDEF in the right places.

This change also removes what was a spurious unreachable 'case 8',
and correctly frees TCG temporaries on the illegal-insn codepaths.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>