tree cafb54a850ceec1a0a29289ce76d993d6e67751a
parent f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71
author Markus Armbruster <armbru@redhat.com> 1392997372 +0100
committer Gerd Hoffmann <kraxel@redhat.com> 1394451304 +0100

vnc: Fix tight_detect_smooth_image() for lossless case

VncTight member uint8_t quality is either (uint8_t)-1 for lossless or
less than 10 for lossy.

tight_detect_smooth_image() first promotes it to int, then compares
with -1.  Always unequal, so we always execute the lossy code.  Reads
beyond tight_conf[] and returns crap when quality is actually
lossless.

Compare to (uint8_t)-1 instead, like we do elsewhere.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>