)]}'
{
  "commit": "3949e59414fccefadc50ae65650d676cc734048c",
  "tree": "bb6d54b1ce4491ec37c74d06cbf6e4aedefa54a9",
  "parents": [
    "5c230105cdea8ac9338bd5b4485c6ae80ec1fa18"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Wed Feb 06 21:27:24 2013 +0100"
  },
  "committer": {
    "name": "Anthony Liguori",
    "email": "aliguori@us.ibm.com",
    "time": "Wed Feb 06 16:35:19 2013 -0600"
  },
  "message": "qemu-char: Saner naming of memchar stuff \u0026 doc fixes\n\nNew device, has never been released, so we can still improve things\nwithout worrying about compatibility.\n\nNaming is a mess.  The code calls the device driver CirMemCharDriver,\nthe public API calls it \"memory\", \"memchardev\", or \"memchar\", and the\nspecial commands are named like \"memchar-FOO\".  \"memory\" is a\nparticularly unfortunate choice, because there\u0027s another character\ndevice driver called MemoryDriver.  Moreover, the device\u0027s distinctive\nproperty is that it\u0027s a ring buffer, not that\u0027s in memory.  Therefore:\n\n* Rename CirMemCharDriver to RingBufCharDriver, and call the thing a\n  \"ringbuf\" in the API.\n\n* Rename QMP and HMP commands from memchar-FOO to ringbuf-FOO.\n\n* Rename device parameter from maxcapacity to size (simple words are\n  good for you).\n\n* Clearly mark the parameter as optional in documentation.\n\n* Fix error reporting so that chardev-add reports to current monitor,\n  not stderr.\n\n* Replace cirmem in C identifiers by ringbuf.\n\n* Rework documentation.  Document the impact of our crappy UTF-8\n  handling on reading.\n\n* QMP examples that even work.\n\nI could split this up into multiple commits, but they\u0027d change the\nsame documentation lines multiple times.  Not worth it.\n\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\nSigned-off-by: Anthony Liguori \u003caliguori@us.ibm.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "bdd48f3469e0cd3fb76d7b4e3ee732e22f005ecf",
      "old_mode": 33188,
      "old_path": "hmp-commands.hx",
      "new_id": "66ec716e03a08a59d090d4aef1353407f2d509ca",
      "new_mode": 33188,
      "new_path": "hmp-commands.hx"
    },
    {
      "type": "modify",
      "old_id": "f6bb7675baef3305f7c48ad964a9078456301865",
      "old_mode": 33188,
      "old_path": "hmp.c",
      "new_id": "cbd572753b6920530e4de948ef289182f90bc5df",
      "new_mode": 33188,
      "new_path": "hmp.c"
    },
    {
      "type": "modify",
      "old_id": "076d8cf378f19892a9fb899207b90ac5182dfbf3",
      "old_mode": 33188,
      "old_path": "hmp.h",
      "new_id": "30b3c20ca4d847fd6c2ceb6ffaaba8a7f06bc6c2",
      "new_mode": 33188,
      "new_path": "hmp.h"
    },
    {
      "type": "modify",
      "old_id": "6f6379151f8da1c1a753fa1793964d82a94c3de8",
      "old_mode": 33188,
      "old_path": "qapi-schema.json",
      "new_id": "736f881b75b3ea26d9cccc661d9c99bc11eb7e40",
      "new_mode": 33188,
      "new_path": "qapi-schema.json"
    },
    {
      "type": "modify",
      "old_id": "831d564a8b63d1fc321118ff9ff576bc33ffb484",
      "old_mode": 33188,
      "old_path": "qemu-char.c",
      "new_id": "8a3540389a464fb1e6b85ebb1a9ba32cfbe39a5c",
      "new_mode": 33188,
      "new_path": "qemu-char.c"
    },
    {
      "type": "modify",
      "old_id": "2d44137bf9a974cc4165d1db9301e0334a0200b8",
      "old_mode": 33188,
      "old_path": "qemu-options.hx",
      "new_id": "046bdc0f6346a9a55bb1659dc9d348c73b67ee72",
      "new_mode": 33188,
      "new_path": "qemu-options.hx"
    },
    {
      "type": "modify",
      "old_id": "51ce2e6b416478311f2e26f29f4018f0582e0f9f",
      "old_mode": 33188,
      "old_path": "qmp-commands.hx",
      "new_id": "799adea1b7a00af5e358e2baacd40b59ebb7d360",
      "new_mode": 33188,
      "new_path": "qmp-commands.hx"
    }
  ]
}
