Google Git
Sign in
qemu-android / qemu-android / 48f4ba671bbb3dd212002d57b72a23375f51619b
commit48f4ba671bbb3dd212002d57b72a23375f51619b[log] [tgz]
authorAlon Levy <alevy@redhat.com>Mon Oct 15 14:54:03 2012 +0200
committerGerd Hoffmann <kraxel@redhat.com>Mon Nov 05 11:49:21 2012 +0100
tree71797b6ea1c0b72b9f0df6e20e27b207b10d5153
parent1cfd981ff1e8ff0858cd71cfae0c7c7ba741f380 [diff]
hw/qxl: guest bug on primary create with stride %4 != 0

Due to usage of pixman for rendering on all spice surfaces we have
pixman's requirement that the stride be word aligned. A guest not
honoring that can crash spice and qemu with it due to failure to create
a surface (in spice-server). Avoid this early on in primary surface
creation and offscreen surface creation.

Recently windows guests got odd width support which triggers a non word
aligned primary surface in 16bit color depth. Off screen surfaces have
always been word aligned, but doesn't hurt to check them here too.

Signed-off-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
1 file changed
tree: 71797b6ea1c0b72b9f0df6e20e27b207b10d5153
  1. audio/
  2. block/
  3. bsd-user/
  4. default-configs/
  5. docs/
  6. fpu/
  7. fsdev/
  8. gdb-xml/
  9. hw/
  10. include/
  11. libcacard/
  12. linux-headers/
  13. linux-user/
  14. net/
  15. pc-bios/
  16. qapi/
  17. qga/
  18. QMP/
  19. qom/
  20. roms/
  21. scripts/
  22. slirp/
  23. sysconfigs/
  24. target-alpha/
  25. target-arm/
  26. target-cris/
  27. target-i386/
  28. target-lm32/
  29. target-m68k/
  30. target-microblaze/
  31. target-mips/
  32. target-openrisc/
  33. target-ppc/
  34. target-s390x/
  35. target-sh4/
  36. target-sparc/
  37. target-unicore32/
  38. target-xtensa/
  39. tcg/
  40. tests/
  41. trace/
  42. ui/
  43. pixman
  44. .exrc
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. a.out.h
  49. acl.c
  50. acl.h
  51. aes.c
  52. aes.h
  53. aio-posix.c
  54. aio-win32.c
  55. alpha-dis.c
  56. alpha.ld
  57. arch_init.c
  58. arch_init.h
  59. arm-dis.c
  60. arm.ld
  61. async.c
  62. balloon.c
  63. balloon.h
  64. bitmap.c
  65. bitmap.h
  66. bitops.c
  67. bitops.h
  68. block-migration.c
  69. block-migration.h
  70. block.c
  71. block.h
  72. block_int.h
  73. blockdev-nbd.c
  74. blockdev.c
  75. blockdev.h
  76. blockjob.c
  77. blockjob.h
  78. bswap.h
  79. bt-host.c
  80. bt-host.h
  81. bt-vhci.c
  82. buffered_file.c
  83. buffered_file.h
  84. cache-utils.c
  85. cache-utils.h
  86. Changelog
  87. cmd.c
  88. cmd.h
  89. CODING_STYLE
  90. compatfd.c
  91. compatfd.h
  92. compiler.h
  93. config.h
  94. configure
  95. console.c
  96. console.h
  97. COPYING
  98. COPYING.LIB
  99. coroutine-gthread.c
  100. coroutine-sigaltstack.c
  101. coroutine-ucontext.c
  102. coroutine-win32.c
  103. cpu-all.h
  104. cpu-common.h
  105. cpu-defs.h
  106. cpu-exec.c
  107. cpus.c
  108. cpus.h
  109. cputlb.c
  110. cputlb.h
  111. cris-dis.c
  112. cursor.c
  113. cursor_hidden.xpm
  114. cursor_left_ptr.xpm
  115. cutils.c
  116. def-helper.h
  117. device_tree.c
  118. device_tree.h
  119. dis-asm.h
  120. disas.c
  121. disas.h
  122. dma-helpers.c
  123. dma.h
  124. dump-stub.c
  125. dump.c
  126. dump.h
  127. elf.h
  128. envlist.c
  129. envlist.h
  130. error.c
  131. error.h
  132. event_notifier-posix.c
  133. event_notifier-win32.c
  134. event_notifier.h
  135. exec-all.h
  136. exec-memory.h
  137. exec.c
  138. gdbstub.c
  139. gdbstub.h
  140. gen-icount.h
  141. HACKING
  142. hmp-commands.hx
  143. hmp.c
  144. hmp.h
  145. host-utils.c
  146. host-utils.h
  147. hppa-dis.c
  148. hppa.ld
  149. hwaddr.h
  150. i386-dis.c
  151. i386.ld
  152. ia64-dis.c
  153. ia64.ld
  154. input.c
  155. int128.h
  156. iohandler.c
  157. ioport.c
  158. ioport.h
  159. iorange.h
  160. iov.c
  161. iov.h
  162. json-lexer.c
  163. json-lexer.h
  164. json-parser.c
  165. json-parser.h
  166. json-streamer.c
  167. json-streamer.h
  168. kvm-all.c
  169. kvm-stub.c
  170. kvm.h
  171. libfdt_env.h
  172. LICENSE
  173. lm32-dis.c
  174. m68k-dis.c
  175. m68k.ld
  176. main-loop.c
  177. main-loop.h
  178. MAINTAINERS
  179. Makefile
  180. Makefile.dis
  181. Makefile.objs
  182. Makefile.target
  183. Makefile.user
  184. memory-internal.h
  185. memory.c
  186. memory.h
  187. memory_mapping-stub.c
  188. memory_mapping.c
  189. memory_mapping.h
  190. microblaze-dis.c
  191. migration-exec.c
  192. migration-fd.c
  193. migration-tcp.c
  194. migration-unix.c
  195. migration.c
  196. migration.h
  197. mips-dis.c
  198. mips.ld
  199. module.c
  200. module.h
  201. monitor.c
  202. monitor.h
  203. nbd.c
  204. nbd.h
  205. net.c
  206. net.h
  207. notify.c
  208. notify.h
  209. os-posix.c
  210. os-win32.c
  211. osdep.c
  212. osdep.h
  213. oslib-posix.c
  214. oslib-win32.c
  215. page_cache.c
  216. path.c
  217. pci-ids.txt
  218. pflib.c
  219. pflib.h
  220. poison.h
  221. ppc-dis.c
  222. ppc.ld
  223. ppc64.ld
  224. qapi-schema-guest.json
  225. qapi-schema-test.json
  226. qapi-schema.json
  227. qbool.c
  228. qbool.h
  229. qdict-test-data.txt
  230. qdict.c
  231. qdict.h
  232. qemu-aio.h
  233. qemu-barrier.h
  234. qemu-bridge-helper.c
  235. qemu-char.c
  236. qemu-char.h
  237. qemu-common.h
  238. qemu-config.c
  239. qemu-config.h
  240. qemu-coroutine-int.h
  241. qemu-coroutine-io.c
  242. qemu-coroutine-lock.c
  243. qemu-coroutine-sleep.c
  244. qemu-coroutine.c
  245. qemu-coroutine.h
  246. qemu-doc.texi
  247. qemu-error.c
  248. qemu-error.h
  249. qemu-file.h
  250. qemu-ga.c
  251. qemu-img-cmds.hx
  252. qemu-img.c
  253. qemu-img.texi
  254. qemu-io.c
  255. qemu-lock.h
  256. qemu-log.c
  257. qemu-log.h
  258. qemu-nbd.c
  259. qemu-nbd.texi
  260. qemu-objects.h
  261. qemu-option-internal.h
  262. qemu-option.c
  263. qemu-option.h
  264. qemu-options-wrapper.h
  265. qemu-options.h
  266. qemu-options.hx
  267. qemu-os-posix.h
  268. qemu-os-win32.h
  269. qemu-pixman.c
  270. qemu-pixman.h
  271. qemu-progress.c
  272. qemu-queue.h
  273. qemu-seccomp.c
  274. qemu-seccomp.h
  275. qemu-sockets.c
  276. qemu-tech.texi
  277. qemu-thread-posix.c
  278. qemu-thread-posix.h
  279. qemu-thread-win32.c
  280. qemu-thread-win32.h
  281. qemu-thread.h
  282. qemu-timer-common.c
  283. qemu-timer.c
  284. qemu-timer.h
  285. qemu-tls.h
  286. qemu-tool.c
  287. qemu-user.c
  288. qemu-x509.h
  289. qemu-xattr.h
  290. qemu.sasl
  291. qemu_socket.h
  292. qerror.c
  293. qerror.h
  294. qfloat.c
  295. qfloat.h
  296. qint.c
  297. qint.h
  298. qjson.c
  299. qjson.h
  300. qlist.c
  301. qlist.h
  302. qmp-commands.hx
  303. qmp.c
  304. qobject.h
  305. qstring.c
  306. qstring.h
  307. qtest.c
  308. qtest.h
  309. range.h
  310. readline.c
  311. readline.h
  312. README
  313. rules.mak
  314. s390-dis.c
  315. s390.ld
  316. savevm.c
  317. sh4-dis.c
  318. softmmu-semi.h
  319. softmmu_defs.h
  320. softmmu_exec.h
  321. softmmu_header.h
  322. softmmu_template.h
  323. sparc-dis.c
  324. sparc.ld
  325. sparc64.ld
  326. spice-qemu-char.c
  327. sysemu.h
  328. tcg-runtime.c
  329. tci-dis.c
  330. tci.c
  331. thread-pool.c
  332. thread-pool.h
  333. thunk.c
  334. thunk.h
  335. TODO
  336. trace-events
  337. translate-all.c
  338. uboot_image.h
  339. uri.c
  340. uri.h
  341. user-exec.c
  342. VERSION
  343. version.rc
  344. vgafont.h
  345. vl.c
  346. vmstate.h
  347. x86_64.ld
  348. xen-all.c
  349. xen-mapcache.c
  350. xen-mapcache.h
  351. xen-stub.c