)]}'
{
  "commit": "4f8586144161d5e680fdef3e09b7e8e9111c2929",
  "tree": "124dff54d53f5eba6a6f0493c7eafffcccf1750f",
  "parents": [
    "684531ad1f69feb1288b9813c3eb47fba992ea96"
  ],
  "author": {
    "name": "Stefan Hajnoczi",
    "email": "stefanha@redhat.com",
    "time": "Sun Jun 22 10:38:36 2014 +0800"
  },
  "committer": {
    "name": "Michael S. Tsirkin",
    "email": "mst@redhat.com",
    "time": "Mon Jun 23 17:38:00 2014 +0300"
  },
  "message": "qemu-char: fix qemu_chr_fe_get_msgfd()\n\nCommit c76bf6bb8fbbb233a7d3641e09229d23747d5ee3 (\"Add chardev API\nqemu_chr_fe_get_msgfds\") broke qemu_chr_fe_get_msgfd() because it\nchanged the return value.\n\nCallers expect -1 if no fd is available.  The commit changed the return\nvalue to 0 (which is a valid file descriptor number) so callers always\ndetected a file descriptor even if none was available.\n\nThis patch fixes qemu-iotests 045:\n\n  $ cd tests/qemu-iotests \u0026\u0026 ./check 045\n  [...]\n  +FAIL: test_add_fd_invalid_fd (__main__.TestFdSets)\n  +----------------------------------------------------------------------\n  +Traceback (most recent call last):\n  +  File \"./045\", line 123, in test_add_fd_invalid_fd\n  +    self.assert_qmp(result, \u0027error/class\u0027, \u0027GenericError\u0027)\n  +  File \"/home/stefanha/qemu/tests/qemu-iotests/iotests.py\", line 232, in assert_qmp\n  +    result \u003d self.dictpath(d, path)\n  +  File \"/home/stefanha/qemu/tests/qemu-iotests/iotests.py\", line 211, in dictpath\n  +    self.fail(\u0027failed path traversal for \"%s\" in \"%s\"\u0027 % (path, str(d)))\n  +AssertionError: failed path traversal for \"error/class\" in \"{u\u0027return\u0027: {u\u0027fdset-id\u0027: 2, u\u0027fd\u0027: 0}}\"\n\nCc: Nikolay Nikolaev \u003cn.nikolaev@virtualopensystems.com\u003e\nSigned-off-by: Stefan Hajnoczi \u003cstefanha@redhat.com\u003e\nReviewed-by: Michael S. Tsirkin \u003cmst@redhat.com\u003e\nSigned-off-by: Michael S. Tsirkin \u003cmst@redhat.com\u003e\n\n\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e4eb985b5746270ba65fc63308e47335cab002bf",
      "old_mode": 33188,
      "old_path": "qemu-char.c",
      "new_id": "d9100a2201ec67fdec2c30b273715f7023eed6c7",
      "new_mode": 33188,
      "new_path": "qemu-char.c"
    }
  ]
}