tree ffa427b0c9df054073f6b9fb17b016697a9339dc
parent ecdd5333ab9ed3f2b848066aaaef02c027b25e36
author Kevin Wolf <kwolf@redhat.com> 1364401698 +0100
committer Stefan Hajnoczi <stefanha@redhat.com> 1364468320 +0100

block: Fix direct use of protocols as driver for bdrv_open()

bdrv_open_common() implements direct use of protocols by copying the
pre-opened BlockDriverStates to bs using bdrv_swap(). It did however
first set some fields in bs, which end up in file after the swap. When
bdrv_open() destroys file, it appears to be open, and because it isn't,
qemu could segfault while trying to close it.

Reorder the operations to return immediately in such cases so that file
is correctly detected as closed.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>