)]}'
{
  "commit": "69ce1ac26dcdd2073d4b4dc0eb52787eb9fca628",
  "tree": "525544a25fdf98dff3cc37cafb6d67e58a3d1d3e",
  "parents": [
    "16c1e3ece4052ebeb2fdf3b6560cca431d0359b9"
  ],
  "author": {
    "name": "John Snow",
    "email": "jsnow@redhat.com",
    "time": "Fri Jan 22 15:50:58 2016 -0500"
  },
  "committer": {
    "name": "John Snow",
    "email": "jsnow@redhat.com",
    "time": "Mon Jan 25 14:35:23 2016 -0500"
  },
  "message": "fdc: Throw an assertion on misconfigured fd_formats table\n\npick_geometry is a convoluted function that makes it difficult to tell\nat a glance what QEMU\u0027s current behavior for choosing a floppy drive\ntype is when it can\u0027t quite identify the diskette.\n\nThe code iterates over all entries in the candidate geometry table\n(\"fd_formats\") and if our specific drive type matches a row in the table,\nthen either \"match\" is set to that entry (an exact match) and the loop\nexits, or \"first_match\" will be non-negative (the first such entry that\nshares the same drive type), and the loop continues. If our specific\ndrive type is NONE, then all drive types in the candidate geometry table\nare considered. After iteration, if \"match\" was not set, we fall back to\n\"first match\".\n\nThis means that either \"match\" was set, or we exited the loop without an\nexact match, in which case:\n\n- If drive type is NONE, the default is truly fd_formats[0], a 1.44MB\n  type, because \"first_match\" will always get set to the first item.\n\n- If drive type is not NONE, pick_geometry\u0027s iteration was fussier and\n  only looked at rows that matched our drive type. However, since all\n  possible drive types are represented in the table, we still know that\n  \"first match\" was set.\n\n- If drive type is not NONE and the fd_formats table lists no options for\n  our drive type, we choose fd_formats[1], an incomprehensibly bizarre\n  choice that can never happen anyway.\n\nCorrect this: If first_match is -1, it can ONLY mean we didn\u0027t edit our\nfd_formats table correctly. Throw an assertion instead.\n\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\nSigned-off-by: John Snow \u003cjsnow@redhat.com\u003e\nMessage-id: 1453495865-9649-6-git-send-email-jsnow@redhat.com\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "18e363bb5419e800ef161225e1d315905e183a9a",
      "old_mode": 33188,
      "old_path": "hw/block/fdc.c",
      "new_id": "a8f0cf27d581c2ea69600a35be657f6a5caf6e8c",
      "new_mode": 33188,
      "new_path": "hw/block/fdc.c"
    }
  ]
}