)]}'
{
  "commit": "6a84cb1f2822e494839b93dd8c7f7f8fa6c261a9",
  "tree": "4cac89f6dfa794568f2d30abedb9e78d8d029da9",
  "parents": [
    "be62a2ebab29eef7dc66c112d60271890ebbbee2"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Wed Dec 21 11:37:57 2011 +0100"
  },
  "committer": {
    "name": "Stefan Hajnoczi",
    "email": "stefanha@linux.vnet.ibm.com",
    "time": "Fri Jan 06 15:07:00 2012 +0000"
  },
  "message": "scsi virtio-blk usb-msd: Clean up device init error messages\n\nReplace\n\n    error_report(\"DEVICE-NAME: MESSAGE\");\n\nby just\n\n    error_report(\"MESSAGE\");\n\nin block device init functions.\n\nDEVICE-NAME is bogus in some cases: it\u0027s \"scsi-disk\" for device\nscsi-hd and scsi-cd, \"virtio-blk-pci\" for virtio-blk-s390, and\n\"usb-msd\" for usb-storage.\n\nThere is no real need to put a device name in the message, because\nerror_report() points to the offending command line option already:\n\n$ qemu-system-x86_64 --nodefaults --enable-kvm -vnc :0 -S -monitor stdio -usb -device virtio-blk-pci\nupstream-qemu: -device virtio-blk-pci: virtio-blk-pci: drive property not set\nupstream-qemu: -device virtio-blk-pci: Device \u0027virtio-blk-pci\u0027 could not be initialized\n\nAnd for a monitor command, it\u0027s obvious anyway:\n\n$ qemu-system-x86_64 --nodefaults --enable-kvm -vnc :0 -S -monitor stdio -usb\n(qemu) device_add virtio-blk-pci\nvirtio-blk-pci: drive property not set\nDevice \u0027virtio-blk-pci\u0027 could not be initialized\n\nReported-by: Amit Shah \u003camit.shah@redhat.com\u003e\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nSigned-off-by: Stefan Hajnoczi \u003cstefanha@linux.vnet.ibm.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "505accdde5373596e74063467ab4bb961ada15bc",
      "old_mode": 33188,
      "old_path": "hw/scsi-disk.c",
      "new_id": "5d8bf53586f9293287366b60e4d1a3abf2963da9",
      "new_mode": 33188,
      "new_path": "hw/scsi-disk.c"
    },
    {
      "type": "modify",
      "old_id": "6f7d3db775fc9235644beb2fa9894363c09d8ace",
      "old_mode": 33188,
      "old_path": "hw/scsi-generic.c",
      "new_id": "0aebcddf6e6c5270e77403e4fcc7002ef65dc9ff",
      "new_mode": 33188,
      "new_path": "hw/scsi-generic.c"
    },
    {
      "type": "modify",
      "old_id": "4c069501253ddcb9c35f0b50a9903843da51ac6c",
      "old_mode": 33188,
      "old_path": "hw/usb-msd.c",
      "new_id": "b87b9290bed804d112c589bd0c4bc94f6d2359d8",
      "new_mode": 33188,
      "new_path": "hw/usb-msd.c"
    },
    {
      "type": "modify",
      "old_id": "ef27421d461dff9243228cec2d20e2c37b17ce7a",
      "old_mode": 33188,
      "old_path": "hw/virtio-blk.c",
      "new_id": "5e81f53e14e77827470b6d32bff192d06d747e89",
      "new_mode": 33188,
      "new_path": "hw/virtio-blk.c"
    }
  ]
}
