)]}'
{
  "commit": "70b9433109ed99217b812f19800de550e2e0ecd5",
  "tree": "5108fd06d2106dfc495b9defab7212eb89b65ab3",
  "parents": [
    "f006cf7fa9a63ba8e4ccf57d46231ce594301727"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Fri Feb 13 12:50:26 2015 +0100"
  },
  "committer": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Mon Jun 22 18:20:39 2015 +0200"
  },
  "message": "QemuOpts: Wean off qerror_report_err()\n\nqerror_report_err() is a transitional interface to help with\nconverting existing monitor commands to QMP.  It should not be used\nelsewhere.\n\nThe only remaining user in qemu-option.c is qemu_opts_parse().  Is it\nused in QMP context?  If not, we can simply replace\nqerror_report_err() by error_report_err().\n\nThe uses in qemu-img.c, qemu-io.c, qemu-nbd.c and under tests/ are\nclearly not in QMP context.\n\nThe uses in vl.c aren\u0027t either, because the only QMP command handlers\nthere are qmp_query_status() and qmp_query_machines(), and they don\u0027t\ncall it.\n\nRemaining uses:\n\n* drive_def(): Command line -drive and such, HMP drive_add and pci_add\n\n* hmp_chardev_add(): HMP chardev-add\n\n* monitor_parse_command(): HMP core\n\n* tmp_config_parse(): Command line -tpmdev\n\n* net_host_device_add(): HMP host_net_add\n\n* net_client_parse(): Command line -net and -netdev\n\n* qemu_global_option(): Command line -global\n\n* vnc_parse_func(): Command line -display, -vnc, default display, HMP\n  change, QMP change.  Bummer.\n\n* qemu_pci_hot_add_nic(): HMP pci_add\n\n* usb_net_init(): Command line -usbdevice, HMP usb_add\n\nPropagate errors through qemu_opts_parse().  Create a convenience\nfunction qemu_opts_parse_noisily() that passes errors to\nerror_report_err().  Switch all non-QMP users outside tests to it.\n\nThat leaves vnc_parse_func().  Propagate errors through it.  Since I\u0027m\ntouching it anyway, rename it to vnc_parse().\n\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\nReviewed-by: Stefan Hajnoczi \u003cstefanha@redhat.com\u003e\nReviewed-by: Luiz Capitulino \u003clcapitulino@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "41d7e0fe5442377cebea143a205c060254bc5d5d",
      "old_mode": 33188,
      "old_path": "blockdev.c",
      "new_id": "3950e90edd6e37c5cc793e141b32ee9501a9bb95",
      "new_mode": 33188,
      "new_path": "blockdev.c"
    },
    {
      "type": "modify",
      "old_id": "458a0c933d6d1c26f12f34ca3b031258d0c53d19",
      "old_mode": 33188,
      "old_path": "hmp.c",
      "new_id": "1375b0d85cbf6de637258f8aa9f279fb08830d7d",
      "new_mode": 33188,
      "new_path": "hmp.c"
    },
    {
      "type": "modify",
      "old_id": "743c231d6bc95c0497bb1a4ab84bf6a2970a591c",
      "old_mode": 33188,
      "old_path": "hw/usb/dev-network.c",
      "new_id": "5eeb4c6b06e58ad917a5af5b14e318b1318c80a0",
      "new_mode": 33188,
      "new_path": "hw/usb/dev-network.c"
    },
    {
      "type": "modify",
      "old_id": "ac0e43b7e515ba1338857cb259a9fedb33a07cd5",
      "old_mode": 33188,
      "old_path": "include/qemu/option.h",
      "new_id": "57e51c96283efe32712507150a4c1748338b23b2",
      "new_mode": 33188,
      "new_path": "include/qemu/option.h"
    },
    {
      "type": "modify",
      "old_id": "de92523bbbb4895677c7b1893582c4e924ef1038",
      "old_mode": 33188,
      "old_path": "include/ui/console.h",
      "new_id": "9ad6c17ecc2d482603da9881506543a9c3a525f5",
      "new_mode": 33188,
      "new_path": "include/ui/console.h"
    },
    {
      "type": "modify",
      "old_id": "02b491a830929b7a7e495fe9b44c94a31693a406",
      "old_mode": 33188,
      "old_path": "monitor.c",
      "new_id": "8fda48833a90b29cfe8db49b31a8ce871a8b0324",
      "new_mode": 33188,
      "new_path": "monitor.c"
    },
    {
      "type": "modify",
      "old_id": "6dbd61a8f2ef4ed4d65351b7160effa4164e0414",
      "old_mode": 33188,
      "old_path": "net/net.c",
      "new_id": "85c4b20d8f1343b512ba89bf8dd8b4ec3441c65e",
      "new_mode": 33188,
      "new_path": "net/net.c"
    },
    {
      "type": "modify",
      "old_id": "f6ceea7ac483af1eb4ad83517b390c4d11fa0b81",
      "old_mode": 33188,
      "old_path": "qdev-monitor.c",
      "new_id": "e1223b27f4195437ab66b0bf765fe6dffb8bfac2",
      "new_mode": 33188,
      "new_path": "qdev-monitor.c"
    },
    {
      "type": "modify",
      "old_id": "60c820d002f5b47d0b7be15fa0d1b8ab0dc69adc",
      "old_mode": 33188,
      "old_path": "qemu-img.c",
      "new_id": "ea964fefb8f1f1aa3b0f5292dee22ca942c7f02c",
      "new_mode": 33188,
      "new_path": "qemu-img.c"
    },
    {
      "type": "modify",
      "old_id": "9bc83c6ec19432592fcc35bb86c9f5464a339ee7",
      "old_mode": 33188,
      "old_path": "qemu-io.c",
      "new_id": "c24f6be24e3af7b6fb8a6d28baac31b1583905d4",
      "new_mode": 33188,
      "new_path": "qemu-io.c"
    },
    {
      "type": "modify",
      "old_id": "5af6d11e3387b070f0ba411b4a3310960273a609",
      "old_mode": 33188,
      "old_path": "qemu-nbd.c",
      "new_id": "7a4bf1bc56e5e1b15a758433a2f8cf5a2e27494f",
      "new_mode": 33188,
      "new_path": "qemu-nbd.c"
    },
    {
      "type": "modify",
      "old_id": "fa013e31b833436439a1ae0b46d8fbaa203fc516",
      "old_mode": 33188,
      "old_path": "qmp.c",
      "new_id": "f2981de706a712b9e575474c9da1552130b93ab9",
      "new_mode": 33188,
      "new_path": "qmp.c"
    },
    {
      "type": "modify",
      "old_id": "ebeee5d5893362194be5c9e70997ec26fd429495",
      "old_mode": 33188,
      "old_path": "tests/test-opts-visitor.c",
      "new_id": "1c753d982431c9504ff0fc4d0d2d3bd5449b1bc6",
      "new_mode": 33188,
      "new_path": "tests/test-opts-visitor.c"
    },
    {
      "type": "modify",
      "old_id": "da564923d04a97592022edbc2ce483a50c70e283",
      "old_mode": 33188,
      "old_path": "tests/test-qemu-opts.c",
      "new_id": "0c1136d1b2aceb976964d8b464585c94cf702f51",
      "new_mode": 33188,
      "new_path": "tests/test-qemu-opts.c"
    },
    {
      "type": "modify",
      "old_id": "a3f3b7f90fc5bd0bb60d96baaece183a64e50761",
      "old_mode": 33188,
      "old_path": "tpm.c",
      "new_id": "b8b066498261aa2aebe2bdc5eee895576e7e8c87",
      "new_mode": 33188,
      "new_path": "tpm.c"
    },
    {
      "type": "modify",
      "old_id": "69b605c709238e0006f94a0dc8095afa94ed59e7",
      "old_mode": 33188,
      "old_path": "ui/vnc.c",
      "new_id": "7f0ce7a9be9916828400abb97d8cdb1787600286",
      "new_mode": 33188,
      "new_path": "ui/vnc.c"
    },
    {
      "type": "modify",
      "old_id": "69da28c7e167a11d26bd57b7404ff46bf3073c44",
      "old_mode": 33188,
      "old_path": "util/qemu-option.c",
      "new_id": "06c63ed6196f2fbfe991b616b0d1a75b1fb2d8f0",
      "new_mode": 33188,
      "new_path": "util/qemu-option.c"
    },
    {
      "type": "modify",
      "old_id": "fd6a5c2ee208134ef2cd851941a6df10bdecff65",
      "old_mode": 33188,
      "old_path": "vl.c",
      "new_id": "34bf0fbbb4ec50caae7da382e7eaaa76d1a54785",
      "new_mode": 33188,
      "new_path": "vl.c"
    }
  ]
}