)]}'
{
  "commit": "7324c10f96c821b00d691e2c8ced67d8536bf1d6",
  "tree": "9f42bbfb21f1d40261aabcc18d4918610750b390",
  "parents": [
    "c6e9d8ae6629aaf3c6d483032d219b988d78583f"
  ],
  "author": {
    "name": "Max Reitz",
    "email": "mreitz@redhat.com",
    "time": "Tue Feb 10 15:28:46 2015 -0500"
  },
  "committer": {
    "name": "Kevin Wolf",
    "email": "kwolf@redhat.com",
    "time": "Tue Mar 10 14:02:21 2015 +0100"
  },
  "message": "qcow2: Only return status from qcow2_get_refcount\n\nRefcounts can theoretically be of type uint64_t; in order to be able to\nrepresent the full range, qcow2_get_refcount() cannot use a single\nvariable to represent both all refcount values and also keep some values\nreserved for errors.\n\nOne solution would be to add an Error pointer parameter to\nqcow2_get_refcount(); however, no caller could (currently) pass that\nerror message, so it would have to be emitted immediately and be\npassed to the next caller by returning -EIO or something similar.\nTherefore, an Error parameter does not offer any advantages here.\n\nThe solution applied by this patch is simpler to use. Because no caller\nwould be able to pass the error message, they would have to print it and\nfree it, whereas with this patch the caller only needs to pass the\nreturned integer (which is often a no-op from the code perspective,\nbecause that integer will be stored in a variable \"ret\" which will be\nreturned by the fail path of many callers).\n\nSigned-off-by: Max Reitz \u003cmreitz@redhat.com\u003e\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\nSigned-off-by: Kevin Wolf \u003ckwolf@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "183177d518044284f27e433daa17cd927d0cad5d",
      "old_mode": 33188,
      "old_path": "block/qcow2-cluster.c",
      "new_id": "ee50500a076dcb39d00be8ee7f8975ce89981453",
      "new_mode": 33188,
      "new_path": "block/qcow2-cluster.c"
    },
    {
      "type": "modify",
      "old_id": "1a85bcd49c7103f699955f56ba3fe70b6d509f7e",
      "old_mode": 33188,
      "old_path": "block/qcow2-refcount.c",
      "new_id": "d8534903c33bbe7724c0ea937e2e6ae1af1ac067",
      "new_mode": 33188,
      "new_path": "block/qcow2-refcount.c"
    },
    {
      "type": "modify",
      "old_id": "55138c9d92036af7ab05619685cd36106ae74950",
      "old_mode": 33188,
      "old_path": "block/qcow2.h",
      "new_id": "a33431f05a91a2b00404ecb0adecae14d934bd36",
      "new_mode": 33188,
      "new_path": "block/qcow2.h"
    }
  ]
}
