)]}'
{
  "commit": "7b045a4a41b16e426aa1ad3dcbb9b41f4bfc409a",
  "tree": "83ff7306dc437ffd282f50a48ccf98cacc5eff37",
  "parents": [
    "e05093dbbf0d1df148117e3ba2df22bc3c0878b9"
  ],
  "author": {
    "name": "David \u0027Digit\u0027 Turner",
    "email": "digit@google.com",
    "time": "Mon Oct 10 18:06:02 2016 +0200"
  },
  "committer": {
    "name": "David \u0027Digit\u0027 Turner",
    "email": "digit@google.com",
    "time": "Tue Oct 18 13:47:31 2016 +0200"
  },
  "message": "android: goldfish_pipe: Remove dependency on AndroidEmu.\n\nThis patch refactors the virtual device used to implement the\nAndroid pipe channels in the following ways:\n\n- Rename the source files from \"android_pipe.c\" to\n  \"goldfish_pipe.c\". It is consistent with the naming of\n  other Android-specific devices, and makes it more\n  explicit that this is a virtual device, not a service\n  implementation (e.g. like android_adb.c in the same\n  directory that was used in the past).\n\n- Remove any includes to AndroidEmu from the virtual device\n  (e.g. \"android/emulation/android_pipe_device.h\"). Instead\n  provide a callback-based interface to be implemented by\n  the host service (GoldfishPipeServiceOps), and injected\n  into the device through goldfish_pipe_set_service_ops().\n\n  This makes the virtual device much easier to rebase in\n  the future, as well as makes it upstreamable.\n\n- Provide a new header \"include/hw/misc/goldfish_pipe.h\"\n  that contains the declaration for the new interface.\n  Note that this also defines types with the GoldfishPipe\n  prefix. This increases type-safety and better documents\n  usage, compared to the liberal use of void* for what\n  is now GoldfishHwPipe and GoldfishHostPipe.\n\n- Provide glue code (android_pipe_device.cpp) that connects\n  the implementation of the generic AndroidEmu pipe service\n  and the QEMU2-specific virtual device, through the new\n  qemu_android_pipe_init() function.\n\n- Ensure that qemu_android_pipe_init() is properly called\n  at emulation setup time.\n\n+ Fixed a minor mis-type (uint32 --\u003e uint32_t) to avoid\n  future compiler warnings (after the 2.7 rebase).\n\n+ Rename pipe_free() to hwpipe_free() for consistency.\n\nNOTE: This should not change the virtual device\u0027s\n      implementation in any way: no bug fix, no new features.\n\nChange-Id: I1caae14330e036b4076abd3883891885e49e1fe6\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e692c273f30fb7e88db16e527c87a23a7a8f9443",
      "old_mode": 33188,
      "old_path": "android-qemu2-glue/build/Makefile.qemu2-glue.mk",
      "new_id": "330fb922c4040512b79ce9ade0a8c2d039606d13",
      "new_mode": 33188,
      "new_path": "android-qemu2-glue/build/Makefile.qemu2-glue.mk"
    },
    {
      "type": "modify",
      "old_id": "26e76d0d4b78165976c427d581f0e87f70780bbc",
      "old_mode": 33188,
      "old_path": "android-qemu2-glue/build/Makefile.qemu2-target.mk",
      "new_id": "621c87c6c93c00f26ebc823b6f45f64baddca468",
      "new_mode": 33188,
      "new_path": "android-qemu2-glue/build/Makefile.qemu2-target.mk"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "744501cf0a794b7228bc76bb8a6cce262d6bce88",
      "new_mode": 33188,
      "new_path": "android-qemu2-glue/emulation/android_pipe_device.cpp"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "efe026692e7671cb00462323cecf38dc8d7cf45d",
      "new_mode": 33188,
      "new_path": "android-qemu2-glue/emulation/android_pipe_device.h"
    },
    {
      "type": "modify",
      "old_id": "11305925a030c6f4d948a3d330b4363df1044f9e",
      "old_mode": 33188,
      "old_path": "android-qemu2-glue/qemu-setup.cpp",
      "new_id": "0bbdb77f109121bc8446bdb2ee6083450b1774a6",
      "new_mode": 33188,
      "new_path": "android-qemu2-glue/qemu-setup.cpp"
    },
    {
      "type": "rename",
      "old_id": "6be9b73284c876b8e435101916b3ca2e8e31cc79",
      "old_mode": 33261,
      "old_path": "hw/misc/android_pipe.c",
      "new_id": "a1d1bd855694dc4cf13aacdf5a6d16d629b5ce4d",
      "new_mode": 33261,
      "new_path": "hw/misc/goldfish_pipe.c",
      "score": 77
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "219ddd6a61cc5baa4ff716985e1452ea3517e679",
      "new_mode": 33188,
      "new_path": "include/hw/misc/goldfish_pipe.h"
    }
  ]
}