)]}'
{
  "commit": "a89d89d3e65800fa4a8e00de7af0ea8272bef779",
  "tree": "b9c2f5d9546f7e15973ced4a254a4e67c1fb2198",
  "parents": [
    "2ea1dd758c45f8ff12c67ed7934c3ce021eeaf12"
  ],
  "author": {
    "name": "Wenchao Xia",
    "email": "xiawenc@linux.vnet.ibm.com",
    "time": "Wed Sep 11 14:04:33 2013 +0800"
  },
  "committer": {
    "name": "Kevin Wolf",
    "email": "kwolf@redhat.com",
    "time": "Thu Sep 12 10:12:47 2013 +0200"
  },
  "message": "snapshot: distinguish id and name in snapshot delete\n\nSnapshot creation actually already distinguish id and name since it take\na structured parameter *sn, but delete can\u0027t. Later an accurate delete\nis needed in qmp_transaction abort and blockdev-snapshot-delete-sync,\nso change its prototype. Also *errp is added to tip error, but return\nvalue is kepted to let caller check what kind of error happens. Existing\ncaller for it are savevm, delvm and qemu-img, they are not impacted by\nintroducing a new function bdrv_snapshot_delete_by_id_or_name(), which\ncheck the return value and do the operation again.\n\nBefore this patch:\n  For qcow2, it search id first then name to find the one to delete.\n  For rbd, it search name.\n  For sheepdog, it does nothing.\n\nAfter this patch:\n  For qcow2, logic is the same by call it twice in caller.\n  For rbd, it always fails in delete with id, but still search for name\nin second try, no change to user.\n\nSome code for *errp is based on Pavel\u0027s patch.\n\nSigned-off-by: Wenchao Xia \u003cxiawenc@linux.vnet.ibm.com\u003e\nSigned-off-by: Pavel Hrdina \u003cphrdina@redhat.com\u003e\nSigned-off-by: Kevin Wolf \u003ckwolf@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ffead08ca2cdd9a292cb482efe70a54119757a50",
      "old_mode": 33188,
      "old_path": "block/qcow2-snapshot.c",
      "new_id": "7d144205c3fdd65bae8a728e2f9d7ad54bb6bdc7",
      "new_mode": 33188,
      "new_path": "block/qcow2-snapshot.c"
    },
    {
      "type": "modify",
      "old_id": "bea6ddb43a442bc1a18b91808e3b3e5ce2b59637",
      "old_mode": 33188,
      "old_path": "block/qcow2.h",
      "new_id": "c90e5d6c6e6cca0f12afb523b98577d958923373",
      "new_mode": 33188,
      "new_path": "block/qcow2.h"
    },
    {
      "type": "modify",
      "old_id": "e798e19f814180998ffb0a2490d8b733d256f326",
      "old_mode": 33188,
      "old_path": "block/rbd.c",
      "new_id": "b1ab80ce191269a7f1c70e7ab808ecd84066ac93",
      "new_mode": 33188,
      "new_path": "block/rbd.c"
    },
    {
      "type": "modify",
      "old_id": "f9988d35ba3fd6a954182acc4098adb6c9a38008",
      "old_mode": 33188,
      "old_path": "block/sheepdog.c",
      "new_id": "fe438e0fa2d129ceb78ffa0beca5e13b4a710aff",
      "new_mode": 33188,
      "new_path": "block/sheepdog.c"
    },
    {
      "type": "modify",
      "old_id": "a923b386b61016d177278c9f7677f40190b42c5c",
      "old_mode": 33188,
      "old_path": "block/snapshot.c",
      "new_id": "82e602fccfde97e416f95818118f1d4e9530c448",
      "new_mode": 33188,
      "new_path": "block/snapshot.c"
    },
    {
      "type": "modify",
      "old_id": "1541777d427426204f66b9f6d34cca2b8009515f",
      "old_mode": 33188,
      "old_path": "include/block/block_int.h",
      "new_id": "e7d1766ae0803949e25178fe2b3e2c2c0c34b2a3",
      "new_mode": 33188,
      "new_path": "include/block/block_int.h"
    },
    {
      "type": "modify",
      "old_id": "9d06dc17a67e26916975331c49444cab0082df87",
      "old_mode": 33188,
      "old_path": "include/block/snapshot.h",
      "new_id": "012bf226d3689e218b3461b35c8a8841ef8473f6",
      "new_mode": 33188,
      "new_path": "include/block/snapshot.h"
    },
    {
      "type": "modify",
      "old_id": "0cf6be228033119d36d1f549aacc69432ece043e",
      "old_mode": 33188,
      "old_path": "qemu-img.c",
      "new_id": "139526f348510636a30e5fe039cdaeee93f98498",
      "new_mode": 33188,
      "new_path": "qemu-img.c"
    },
    {
      "type": "modify",
      "old_id": "c536aa4986bd5381d53f363577c4cf4a5e3465b4",
      "old_mode": 33188,
      "old_path": "savevm.c",
      "new_id": "4a3c819fcdda5a4ded652c510f6178a03f9324d9",
      "new_mode": 33188,
      "new_path": "savevm.c"
    }
  ]
}