)]}'
{
  "commit": "b37a2e4576530597dda880387e3f4da52c42b5b5",
  "tree": "9436b9256db9deb3981c0a7ae5bd807819b5df13",
  "parents": [
    "3f668b6c5dc9747d0367837532c3b2ce0520cc17"
  ],
  "author": {
    "name": "Michael Tokarev",
    "email": "mjt@tls.msk.ru",
    "time": "Wed Sep 19 12:08:31 2012 +0400"
  },
  "committer": {
    "name": "Anthony Liguori",
    "email": "aliguori@us.ibm.com",
    "time": "Thu Jan 24 09:45:03 2013 -0600"
  },
  "message": "Revert \"serial: fix retry logic\"\n\nThis reverts commit 67c5322d7000fd105a926eec44bc1765b7d70bdd:\n\n    I\u0027m not sure if the retry logic has ever worked when not using FIFO mode.  I\n    found this while writing a test case although code inspection confirms it is\n    definitely broken.\n\n    The TSR retry logic will never actually happen because it is guarded by an\n    \u0027if (s-\u003etsr_rety \u003e 0)\u0027 but this is the only place that can ever make the\n    variable greater than zero.  That effectively makes the retry logic an \u0027if (0)\n\n    I believe this is a typo and the intention was \u003e\u003d 0.  Once this is fixed thoug\n    I see double transmits with my test case.  This is because in the non FIFO\n    case, serial_xmit may get invoked while LSR.THRE is still high because the\n    character was processed but the retransmit timer was still active.\n\n    We can handle this by simply checking for LSR.THRE and returning early.  It\u0027s\n    possible that the FIFO paths also need some attention.\n\n    Cc: Stefano Stabellini \u003cstefano.stabellini@eu.citrix.com\u003e\n    Signed-off-by: Anthony Liguori \u003caliguori@us.ibm.com\u003e\n\nEven if the previous logic was never worked, new logic breaks stuff -\nnamely,\n\n qemu -enable-kvm -nographic -kernel /boot/vmlinuz-$(uname -r) -append console\u003dttyS0 -serial pty\n\nthe above command will cause the virtual machine to stuck at startup\nusing 100% CPU till one connects to the pty and sends any char to it.\n\nNote this is rather typical invocation for various headless virtual\nmachines by libvirt.\n\nSo revert this change for now, till a better solution will be found.\n\nSigned-off-by: Michael Tokarev \u003cmjt@tls.msk.ru\u003e\nSigned-off-by: Anthony Liguori \u003caliguori@us.ibm.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a5b2a0c6093ac25ea404044744822082a365fb8f",
      "old_mode": 33188,
      "old_path": "hw/serial.c",
      "new_id": "f0ce9b0c15001d67e7783a9299d09ba34e6c6892",
      "new_mode": 33188,
      "new_path": "hw/serial.c"
    }
  ]
}