)]}'
{
  "commit": "b77e7c8e99f9ac726c4eaa2fc3461fd886017dc0",
  "tree": "ed4975227ff5a2fe955ea81f36caf6469bbff8e6",
  "parents": [
    "5ea530491fe9ac56f75bc1833cc3fd7722b24efd"
  ],
  "author": {
    "name": "Paolo Bonzini",
    "email": "pbonzini@redhat.com",
    "time": "Mon Oct 12 15:35:16 2015 +0200"
  },
  "committer": {
    "name": "Paolo Bonzini",
    "email": "pbonzini@redhat.com",
    "time": "Mon Oct 12 18:29:26 2015 +0200"
  },
  "message": "qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts\n\nThe QemuOpts-based code treats \"option not set\" and \"option set\nto false\" the same way for the ipv4 and ipv6 options, because it\nis meant to handle only the \",ipv4\" and \",ipv6\" substrings in\nhand-crafted option parsers.\n\nWhen converting InetSocketAddress to QemuOpts, however, it is\nnecessary to handle all three cases (not set, set to true, set\nto false).  Currently we are not handling all cases correctly.\nThe rules are:\n\n* if none or both options are absent, leave things as is\n\n* if the single present option is Y, the other should be N.\nThis can be implemented by leaving things as is, or by setting\nthe other option to N as done in this patch.\n\n* if the single present option is N, the other should be Y.\nThis is handled by the \"else if\" branch of this patch.\n\nThis ensures that the ipv4 option has an effect on Windows,\nwhere creating the socket with PF_UNSPEC makes an ipv6\nsocket.  With this patch, \",ipv4\" will result in a PF_INET\nsocket instead.\n\nReported-by: Sair, Umair \u003cUmair_Sair@mentor.com\u003e\nTested-by: Sair, Umair \u003cUmair_Sair@mentor.com\u003e\nReviewed-by: Daniel P. Berrange \u003cberrange@redhat.com\u003e\nSigned-off-by: Paolo Bonzini \u003cpbonzini@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2add83a0fcf79ad580e4606381430696fc55a86e",
      "old_mode": 33188,
      "old_path": "util/qemu-sockets.c",
      "new_id": "0a041a922ebe473809cb98dff217ca1fc1d0d4f5",
      "new_mode": 33188,
      "new_path": "util/qemu-sockets.c"
    }
  ]
}