commit bb16172c52ac18742f3df156912c169904e92147
author Peter Maydell <peter.maydell@linaro.org> Sat Dec 24 23:37:24 2011 +0000
committer Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> Fri Jan 06 15:07:14 2012 +0000
tree 04362893c6a2603f59f8c139427706d9db9ec2d9
parent 359bc95d3e604e22fe07be62f5099148a2bb4e6f

gdbstub: Fix fd leak in gdbserver_open() error path

Fix a leak of a file descriptor in error exit paths in
gdbserver_open().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

gdbstub.c

diff --git a/gdbstub.c b/gdbstub.c
index a5806ef..7d470b6 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2762,11 +2762,13 @@
     ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
     if (ret < 0) {
         perror("bind");
+        close(fd);
         return -1;
     }
     ret = listen(fd, 0);
     if (ret < 0) {
         perror("listen");
+        close(fd);
         return -1;
     }
     return fd;