commit d4f4a3efdf0a71621ae5351176f5f15b522d0026
author Markus Armbruster <armbru@redhat.com> Fri Jan 11 11:25:01 2013 +0100
committer Michael Roth <mdroth@linux.vnet.ibm.com> Mon Jan 14 12:07:59 2013 -0600
tree 38579b1bd2aaede9f6bbbf76b07c8ffff57657c8
parent 32c16620dda8ba16f6d6bcd20efefdec8975af77

qemu-ga: Plug fd leak on ga_channel_open() error paths

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>

qga/channel-posix.c

diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index 9a5c05d..05e8386 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -154,6 +154,7 @@
         ret = ga_channel_client_add(c, fd);
         if (ret) {
             g_critical("error adding channel to main loop");
+            close(fd);
             return false;
         }
         break;