)]}'
{
  "commit": "d7bea75d35a44023efc9d481d3a1a2600677b2ef",
  "tree": "2aee9398b3fe56a8d13897ae09a6ca2595f2b385",
  "parents": [
    "6e8e5cb9aa663ba59d4ca0f4cb8307d75163e31a"
  ],
  "author": {
    "name": "Eric Blake",
    "email": "eblake@redhat.com",
    "time": "Fri Jan 29 06:48:38 2016 -0700"
  },
  "committer": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Mon Feb 08 17:29:54 2016 +0100"
  },
  "message": "qapi: Avoid use of misnamed DO_UPCAST()\n\nThe macro DO_UPCAST() is incorrectly named: it converts from a\nparent class to a derived class (which is a downcast).  Better,\nand more consistent with some of the other qapi visitors, is\nto use the container_of() macro through a to_FOO() helper.  Names\nlike \u0027to_ov()\u0027 may be a bit short, but for a static helper it\ndoesn\u0027t hurt too much, and matches existing practice in files\nlike qmp-input-visitor.c.\n\nOur current definition of container_of() is weaker than\nDO_UPCAST(), in that it does not require the derived class to\nhave Visitor as its first member, but this does not hurt our\nusage patterns in qapi visitors.\n\nSigned-off-by: Eric Blake \u003ceblake@redhat.com\u003e\nReviewed-by: Marc-André Lureau \u003cmarcandre.lureau@redhat.com\u003e\nMessage-Id: \u003c1454075341-13658-3-git-send-email-eblake@redhat.com\u003e\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "eb7d85b0ec72d12a201b490532115520b86a3308",
      "old_mode": 33188,
      "old_path": "qapi/opts-visitor.c",
      "new_id": "4955ac833fd6a5a7d6ae68b6aca0ce52702ad371",
      "new_mode": 33188,
      "new_path": "qapi/opts-visitor.c"
    },
    {
      "type": "modify",
      "old_id": "8c5ff7e1d2e8ba55197fc80bcd4d20a0ca995b01",
      "old_mode": 33188,
      "old_path": "qapi/string-input-visitor.c",
      "new_id": "52db4cf32b1fa7eab8c439b17f2ff8c589701064",
      "new_mode": 33188,
      "new_path": "qapi/string-input-visitor.c"
    },
    {
      "type": "modify",
      "old_id": "b04cec4cf7a110cd4095ad0785f6f7b3ea366d2c",
      "old_mode": 33188,
      "old_path": "qapi/string-output-visitor.c",
      "new_id": "b0313cb53a99fb4f11f353ccba2be3be2f8f55ce",
      "new_mode": 33188,
      "new_path": "qapi/string-output-visitor.c"
    }
  ]
}
