)]}'
{
  "commit": "da725d0b0e843ab496e0be6b9ead3cdd55cc0e3d",
  "tree": "7c9302a8525abdb90cc9da035ab5f99e361c37f7",
  "parents": [
    "76823c6e79583c926d127c33926aaf39475e5cda"
  ],
  "author": {
    "name": "Denis V. Lunev",
    "email": "den@openvz.org",
    "time": "Wed Oct 08 13:13:30 2014 +0400"
  },
  "committer": {
    "name": "Stefan Hajnoczi",
    "email": "stefanha@redhat.com",
    "time": "Mon Nov 03 09:48:41 2014 +0000"
  },
  "message": "block/parallels: fix access to not initialized memory in catalog_bitmap\n\nfound by valgrind.\n\nCommand: ./qemu-img convert -f parallels -O qcow2 1.hds 1.img\nInvalid read of size 4\n   at 0x17D0EF: parallels_co_read (parallels.c:357)\n   by 0x11FEE4: bdrv_aio_rw_vector (block.c:4640)\n   by 0x11FFBF: bdrv_aio_readv_em (block.c:4652)\n   by 0x11F55F: bdrv_co_readv_em (block.c:4862)\n   by 0x123428: bdrv_aligned_preadv (block.c:3056)\n   by 0x1239FA: bdrv_co_do_preadv (block.c:3162)\n   by 0x125424: bdrv_rw_co_entry (block.c:2706)\n   by 0x155DD9: coroutine_trampoline (coroutine-ucontext.c:118)\n   by 0x6975B6F: ??? (in /lib/x86_64-linux-gnu/libc-2.19.so)\n\nThe problem is that s-\u003ecatalog_bitmap is allocated/filled as\ngmalloc(s-\u003ecatalog_size) thus index validity check must be\ninclusive, i.e. index \u003e\u003d s-\u003ecatalog_size is invalid.\n\nSigned-off-by: Denis V. Lunev \u003cden@openvz.org\u003e\nReviewed-by: Paolo Bonzini \u003cpbonzini@redhat.com\u003e\nMessage-id: 1412759610-2257-4-git-send-email-den@openvz.org\nCC: Jeff Cody \u003cjcody@redhat.com\u003e\nCC: Kevin Wolf \u003ckwolf@redhat.com\u003e\nCC: Stefan Hajnoczi \u003cstefanha@redhat.com\u003e\nSigned-off-by: Stefan Hajnoczi \u003cstefanha@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2a814f3db4253695cf85b2a6f63fabc202ae808a",
      "old_mode": 33188,
      "old_path": "block/parallels.c",
      "new_id": "4f9cd8dd2310b3f85fdc89b58c85590f398c18cb",
      "new_mode": 33188,
      "new_path": "block/parallels.c"
    }
  ]
}
