)]}'
{
  "commit": "de305b1387dad4473ae4cec48467d10d949e0f10",
  "tree": "b52e6efe83298465cf8bfd1e933d59dbbef3e79e",
  "parents": [
    "65074706b9353bae7307fcfcbbf63a36f6896aa7"
  ],
  "author": {
    "name": "Nikolaus Rath",
    "email": "Nikolaus@rath.org",
    "time": "Wed Apr 25 18:51:27 2012 -0400"
  },
  "committer": {
    "name": "Jan Kiszka",
    "email": "jan.kiszka@siemens.com",
    "time": "Tue May 01 19:08:44 2012 -0300"
  },
  "message": "slirp: don\u0027t use \"smb ports \u003d 0\" option\n\nThe \"smb ports \u003d 0\" option causes recent samba versions to crash. It was\nintroduced in commit 157777ef3e with log message \"Samba 3 support\".\nHowever, a value of 0 has never been officially supported by smb and is\nalso not necessary: if stdin is a socket, smb does not try to listen on\nany ports and uses just stdin. This is necessary to support inetd based\noperation (otherwise smbd would always fail when called from inetd,\nbecause inetd already listens on the SMB port). Since samba has\nsupported inetd operation since pre-3.x, it should be safe to rely on\nthis feature. I have tested it with Samba 3.6.4 -- communication works\nfine, and smbd is not listening on any ports.\n\nI suspect the \"smb ports \u003d 0\" hack may have been introduced when someone\ntested the qemu generated samba config from the command line with \"smbd\n-i\" and found it to fail (because then stdin isn\u0027t a socket).\n\nSigned-off-by: Nikolaus Rath \u003cNikolaus@rath.org\u003e\nSigned-off-by: Jan Kiszka \u003cjan.kiszka@siemens.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "18e07ba609c3be93757d96364583ee65a9180f33",
      "old_mode": 33188,
      "old_path": "net/slirp.c",
      "new_id": "f49043b5ae878ddb86f9462e7a4990aa93a3a961",
      "new_mode": 33188,
      "new_path": "net/slirp.c"
    }
  ]
}
