)]}'
{
  "commit": "e1c8237df5395f6a453f18109bd9dd33fb2a397c",
  "tree": "61c1ceb62a882b7258b177c26fb7b41c37d4ed66",
  "parents": [
    "4715d42efe8632b0f9d2594a80e917de45e4ef88"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Tue Aug 25 20:00:46 2015 +0200"
  },
  "committer": {
    "name": "Andreas Färber",
    "email": "afaerber@suse.de",
    "time": "Sat Sep 19 08:10:12 2015 +0200"
  },
  "message": "qom: Fix invalid error check in property_get_str()\n\nWhen a function returns a null pointer on error and only on error, you\ncan do\n\n    if (!foo(foos, errp)) {\n        ... handle error ...\n    }\n\ninstead of the more cumbersome\n\n    Error *err \u003d NULL;\n\n    if (!foo(foos, \u0026err)) {\n        error_propagate(errp, err);\n        ... handle error ...\n    }\n\nA StringProperty\u0027s getter, however, may return null on success!  We\nthen fail to call visit_type_str().\n\nScrewed up in 6a146eb, v1.1.\n\nFails tests/qom-test in my current, heavily hacked QAPI branch.  No\nreproducer for master known (but I didn\u0027t look hard).\n\nCc: Anthony Liguori \u003canthony@codemonkey.ws\u003e\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\nCc: qemu-stable@nongnu.org\nSigned-off-by: Andreas Färber \u003cafaerber@suse.de\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f28d7038260d8186b94ed77f4df4a9e9826e4651",
      "old_mode": 33188,
      "old_path": "qom/object.c",
      "new_id": "48053281efbcaffae78a50cfbf1426181f99aafa",
      "new_mode": 33188,
      "new_path": "qom/object.c"
    }
  ]
}
