)]}'
{
  "commit": "ed238ba2a0239368dd0cec9bfaf3300a5bd303ce",
  "tree": "8838766f79ba176587d4b2730a766c45caec1701",
  "parents": [
    "a5ec494e274ddcad6d487e3872e16964ef57e0de"
  ],
  "author": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Wed Mar 11 18:39:16 2015 +0100"
  },
  "committer": {
    "name": "Markus Armbruster",
    "email": "armbru@redhat.com",
    "time": "Mon Jun 22 18:20:39 2015 +0200"
  },
  "message": "qdev-monitor: Fix check for full bus\n\nProperty bus has always been too screwed up to be really usable for\nvalues other than plain bus IDs.  This just fixes a bug that crept in\nin commit 1395af6 \"qdev: add a maximum device allowed field for the\nbus.\"\n\nIt doesn\u0027t always fail when it should:\n\n    $ qemu-system-x86_64 -nodefaults -device virtio-serial-pci -device virtio-rng-device,bus\u003dpci.0/virtio-serial-pci/virtio-bus\n\nHappily plugs the virtio-rng-device into the virtio-bus provided by\nvirtio-serial-pci, even though its only slot is already occupied by a\nvirtio-serial-device.\n\nAnd sometimes fails when it shouldn\u0027t:\n\n    $ qemu-system-x86_64 -nodefaults -device virtio-serial-pci -device virtserialport,bus\u003dvirtio-bus/virtio-serial-device\n\nYes, the virtio-bus is full, but the virtio-serial-bus provided by\nvirtio-serial-device isn\u0027t, and that\u0027s the one we\u0027re trying to use.\n\nRoot cause: we check \"bus full\" when we resolve the first element of\nthe path.  That\u0027s the correct one only when it\u0027s also the last one.\n\nFix by moving the \"bus full\" check to right before we return a bus.\n\nSigned-off-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nReviewed-by: Eric Blake \u003ceblake@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2c4d4c89bdaef660e814f1756450a3ba0548ef7a",
      "old_mode": 33188,
      "old_path": "qdev-monitor.c",
      "new_id": "afc0395db6a1b7ff55ced289d1b89ee5f54469e4",
      "new_mode": 33188,
      "new_path": "qdev-monitor.c"
    }
  ]
}
