)]}'
{
  "commit": "f46e720a82ccdf1a521cf459448f3f96ed895d43",
  "tree": "7d73a6f642670a82d1d627f07153c577ff71981c",
  "parents": [
    "b91f93243bbe36dc436a64a662a9bbfb2362534a"
  ],
  "author": {
    "name": "Laszlo Ersek",
    "email": "lersek@redhat.com",
    "time": "Thu Nov 28 18:12:59 2013 +0100"
  },
  "committer": {
    "name": "Anthony Liguori",
    "email": "aliguori@amazon.com",
    "time": "Mon Dec 16 15:33:48 2013 -0800"
  },
  "message": "qemu_opts_parse(): always check return value\n\nqemu_opts_parse() can always return NULL, even if the QemuOptsList.desc in\nquestion would be trivial to satisfy (eg. because it\u0027s empty). For\nexample:\n\nqemu_opts_parse()\n  opts_parse()\n    qemu_opts_create()\n      id_wellformed()\n\nIn practice:\n\n  $ .../qemu-system-x86_64 -acpitable id\u003d3\n  qemu-system-x86_64: -acpitable id\u003d3: Parameter \u0027id\u0027 expects an identifier\n  **\n  ERROR:vl.c:3491:main: assertion failed: (opts !\u003d NULL)\n  Aborted (core dumped)\n\n  $ .../qemu-system-x86_64 -smbios id\u003d3\n  qemu-system-x86_64: -smbios id\u003d3: Parameter \u0027id\u0027 expects an identifier\n  Segmentation fault (core dumped)\n\nI checked all qemu_opts_parse() invocations (and all drive_def()\ninvocations too, because it blindly forwards the former\u0027s retval). Only\nthe two above examples look problematic.\n\nSigned-off-by: Laszlo Ersek \u003clersek@redhat.com\u003e\nReviewed-by: Markus Armbruster \u003carmbru@redhat.com\u003e\nMessage-id: 1385658779-7529-1-git-send-email-lersek@redhat.com\nSigned-off-by: Anthony Liguori \u003caliguori@amazon.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "60dbbcb347d8d3b465230074da34d284db63f42c",
      "old_mode": 33188,
      "old_path": "vl.c",
      "new_id": "7511e7036c1f3a932b5510d599d5e9ba93a63ff8",
      "new_mode": 33188,
      "new_path": "vl.c"
    }
  ]
}